From 1f7c223749b71d4e4976d0b294b37d766655ea95 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kacper=20Michaj=C5=82ow?= Date: Mon, 13 May 2024 17:34:09 +0200 Subject: [PATCH] av_common: fix integer overflow when adjusting timebase Found by OSS-Fuzz. --- common/av_common.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/common/av_common.c b/common/av_common.c index 277601d2fc..1a23d766b3 100644 --- a/common/av_common.c +++ b/common/av_common.c @@ -143,12 +143,14 @@ AVRational mp_get_codec_timebase(const struct mp_codec_params *c) // If the timebase is too coarse, raise its precision, or small adjustments // to timestamps done between decoder and demuxer could be lost. + int64_t den = tb.den; if (av_q2d(tb) > 0.001) { - AVRational r = av_div_q(tb, (AVRational){1, 1000}); - tb.den *= (r.num + r.den - 1) / r.den; + int64_t scaling_num = tb.num * INT64_C(1000); + int64_t scaling_den = tb.den; + den *= (scaling_num + scaling_den - 1) / scaling_den; } - av_reduce(&tb.num, &tb.den, tb.num, tb.den, INT_MAX); + av_reduce(&tb.num, &tb.den, tb.num, den, INT_MAX); if (tb.num < 1 || tb.den < 1) tb = AV_TIME_BASE_Q;