options: remove obsolete --fsmode-dontuse

DOCS/man/en/changes.rst

@@ -164,6 +164,7 @@ Command Line Switches
     ``-font``                   ``--osd-font``
     ``-forcedsubsonly``         ``--sub-forced-only``
     ``-format``                 ``--audio-format``
+    ``-fsmode-dontuse``         (removed)
     ``-fstype``                 ``--x11-fstype``
     ``-hardframedrop``          ``--framedrop=hard``
     ``-lavdopts ...``           ``--vd-lavc-...``

DOCS/man/en/options.rst

@@ -889,10 +889,6 @@ OPTIONS
 
     See also ``--screen``.
 
-``--fsmode-dontuse=<0-31>``
-    *OBSOLETE*, use the ``--fs`` option.
-    Try this option if you still experience fullscreen problems.
-
 ``--x11-fstype=<type1,type2,...>``
     (X11 only)
     Specify a priority list of fullscreen modes to be used. You can negate the

options/options.c

@@ -480,8 +480,6 @@ const m_option_t mp_opts[] = {
     // start in fullscreen mode:
     OPT_FLAG("fullscreen", vo.fullscreen, M_OPT_FIXED),
     OPT_FLAG("fs", vo.fullscreen, M_OPT_FIXED),
-    // set fullscreen switch method (workaround for buggy WMs)
-    OPT_INTRANGE("fsmode-dontuse", vo.fsmode, 0, 31, 4096),
     OPT_FLAG("native-keyrepeat", vo.native_keyrepeat, M_OPT_FIXED),
     OPT_FLOATRANGE("panscan", vo.panscan, 0, 0.0, 1.0),
     OPT_FLOATRANGE("video-zoom", vo.zoom, 0, -20.0, 20.0),
@@ -662,7 +660,6 @@ const struct MPOpts mp_default_opts = {
         .screen_id = -1,
         .fsscreen_id = -1,
         .enable_mouse_movements = 1,
-        .fsmode = 0,
         .panscan = 0.0f,
         .keepaspect = 1,
         .border = 1,

options/options.h

@@ -28,7 +28,6 @@ typedef struct mp_vo_opts {
     struct m_geometry autofit;
     struct m_geometry autofit_larger;
 
-    int fsmode;
     int keepaspect;
     int border;
 

video/out/x11_common.c

@@ -633,11 +633,6 @@ static void vo_x11_decoration(struct vo *vo, int d)
     if (!vo->opts->WinID)
         return;
 
-    if (vo->opts->fsmode & 8) {
-        XSetTransientForHint(x11->display, x11->window,
-                             RootWindow(x11->display, x11->screen));
-    }
-
     vo_MotifHints = XInternAtom(x11->display, "_MOTIF_WM_HINTS", 0);
     if (vo_MotifHints != None) {
         if (!x11->got_motif_hints) {
@@ -664,13 +659,12 @@ static void vo_x11_decoration(struct vo *vo, int d)
             vo_MotifWmHints.functions = x11->oldfuncs;
             d = x11->olddecor;
         }
-        vo_MotifWmHints.decorations =
-            d | ((vo->opts->fsmode & 2) ? MWM_DECOR_MENU : 0);
+        vo_MotifWmHints.decorations = d;
         XChangeProperty(x11->display, x11->window, vo_MotifHints,
                         vo_MotifHints, 32,
                         PropModeReplace,
                         (unsigned char *) &vo_MotifWmHints,
-                        (vo->opts->fsmode & 4) ? 4 : 5);
+                        5);
     }
 }